Fix bug when load an one-node pose graph.#495
Merged
SteveMacenski merged 1 commit intoSteveMacenski:ros2from May 27, 2022
kehanXue:ros2
Merged
Fix bug when load an one-node pose graph.#495SteveMacenski merged 1 commit intoSteveMacenski:ros2from kehanXue:ros2
SteveMacenski merged 1 commit intoSteveMacenski:ros2from
kehanXue:ros2
Conversation
SteveMacenski
approved these changes
May 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Fixed the bug of ceres-solver plugin that when load a one-node pose graph.
Although such a one-node pose graph is not normally loaded, this is really a bug that can crash the program. When a pose-graph only contain one node, which means that there is no constraint has been add in ceres problem. In this suitation
problem_->SetParameterBlockConstantwill abort the program.Description of documentation updates required from your changes
N/A
Future work that may be required in bullet points
N/A